[DX9] Glitchy Graphics? Fix inside...

[hwc.terror]

First of all, I apologize for creating a lot of threads lately, but this should be the last one really.

If you are one of those people that can't run the OpenGL plug-in, but you can run the DirectX 9 plugin. Then you may want to try out the following:

Basically I have an Intel integrated graphics card which can only run DirectX 9 plugin, but I have noticed that the text along with other textures is completely messed up with the current DX9 plugin, so after trying to bug developers I got sick of it and decided to fix the problem myself.

So here I am, fixed the problem and it works perfectly.

Download at: Filebeam - Free Fast File Hosting
or
See attachment

Installation Instructions
Simply un-zip/extract the file to your Dolphin Directory\Plugins\
Replace any existing file if asked so

(Make a backup of your old plugin though, just incase)

This is tested with the latest revision at the time, 1180.

I have also added a 320x240 resolution for those who would like to squeeze out every bit of FPS from their machine, although I don't see why anyone would want to play at that resolution.

Note: I have not tested this on NVidia or ATI cards, but in theory it should work fine, perhaps it's a bit slower, since I have 'temporarily' (until I find a better solution) removed the SSE2 texture decoding and replaced it with the old code that used to decode textures.

I should probably add a checkbox in Dolphin Options where you can enable/disable use of SSE2 for Texture Decoding, and after that I'll send a .diff to the developers so they can add it to the SVN.

Some screenshots




Have fun, and let me know if it works for you so I can continue work on it.

Attached Files

Intel-DX9-Plugin.zip (128.6 KB, 136 views)

__________________
Vista Home Premium
Intel Core 2 Duo 1.66GHZ (T5450)
2048MB RAM
Integrated GFX: Intel X3100 358MB (Chipset: Intel Mobile Express GM965 (Pixel Shader 4, DX10))

(Toshiba A200-1YO Notebook)

[Bianc0neri]

Very nice. I think my laptop is going to love this one. I'm also using an integrated graphics chip from Intel.

__________________
Desktop PC:
| Primary OS: Windows Vista x86 (32-BIT) SP1 || CPU: AMD Athlon 64 X2 5600+ 2.8GHz Socket AM2 2MB L2 || Graphics card: GeForce 8800GT 600 MHz 1919 MB || Motherboard: Socket AM2 Motherboard || Sound Card: SteelSeries USB Soundcard || RAM: 4GB, DDR2 800MHz PC2-6400 || HDD1: SATA2 320 GB, 7200RPM ||

[hwc.terror]

Hehe ^^

Let me know if it works for you too

__________________
Vista Home Premium
Intel Core 2 Duo 1.66GHZ (T5450)
2048MB RAM
Integrated GFX: Intel X3100 358MB (Chipset: Intel Mobile Express GM965 (Pixel Shader 4, DX10))

(Toshiba A200-1YO Notebook)

[Bianc0neri]

Well, going to report if it works later. ^^

__________________
Desktop PC:
| Primary OS: Windows Vista x86 (32-BIT) SP1 || CPU: AMD Athlon 64 X2 5600+ 2.8GHz Socket AM2 2MB L2 || Graphics card: GeForce 8800GT 600 MHz 1919 MB || Motherboard: Socket AM2 Motherboard || Sound Card: SteelSeries USB Soundcard || RAM: 4GB, DDR2 800MHz PC2-6400 || HDD1: SATA2 320 GB, 7200RPM ||

[RockmanForte]

I think a developer of DX9 should continue because of people who dont have OGL. DX9 deserve one. Why dont you people out there who doesnt have OGL make a petition lists and send to the developer and tell them that they should continue DX9. I hope they would listen and go for it. To me, I think OGL and DX9 deserve both instead of just OGL.

__________________
I have:

Wii: Starfall, Neogamma R8 beta 11, and currently on 3.2u
PSP PHAT: 1001k [TA-081] Custom Firmware 5.50 GEN-D2(FULL)

CASE: EagleTech Sidewinder Gaming Tower Case w/420W Power Supply Black
OS: Windows 7 Ultimate 64bit
CPU: Intel core 2 Duo Processor E8400 (2x 3.0GHz/6MB L2 Cache/1333FSB)
Processor Cooling: Thermaltake V1 CPU Cooling Fan System Kit Silent & Overclocking Proof
Graphics Card: NVIDIA GeForce 8800GT 512MB w/DVI + TV Out Video
Memory: 2048GB [1024GB X2] DDR2-800 PC6400 Memory Module Corsair-Value or Major Brand
Sound Card: 3D Premium Surround Sound Onboard

[Squall-Leonhart]

Rockmanforte, petitioning anything is lame, and just screams "STOP DEVELOPING" to me.

I'd expect if ector got some lame as petition in his email he'd commit his current code and stop working on it.

__________________

VBA-M | Xtemu | NGOHQ | Post Impact Productions | TNHW | XBCD 0.2.6 | Satanic666's Emulator Compiles
Don't be a NOOB, READ THE NGEmu/EmuForums Rules of Conduct
Need Help with ePSXe? This is your first stop!.
If you don't post all the required information, you don't get help.
Everytime someone posts a romsite, God kills a beautiful woman.

[RockmanForte]

Yeah... heh! Maybe a petitioning is a bad word for the developer. At least, bring DX9 back.. It deserve one.

__________________
I have:

Wii: Starfall, Neogamma R8 beta 11, and currently on 3.2u
PSP PHAT: 1001k [TA-081] Custom Firmware 5.50 GEN-D2(FULL)

CASE: EagleTech Sidewinder Gaming Tower Case w/420W Power Supply Black
OS: Windows 7 Ultimate 64bit
CPU: Intel core 2 Duo Processor E8400 (2x 3.0GHz/6MB L2 Cache/1333FSB)
Processor Cooling: Thermaltake V1 CPU Cooling Fan System Kit Silent & Overclocking Proof
Graphics Card: NVIDIA GeForce 8800GT 512MB w/DVI + TV Out Video
Memory: 2048GB [1024GB X2] DDR2-800 PC6400 Memory Module Corsair-Value or Major Brand
Sound Card: 3D Premium Surround Sound Onboard

[Axel32]

umm,the dolphin emu on my laptop seems to not be able to load this modified DX9 plugin,help?
p.s. it can load and use the original DX9 plugin with no problem at all

[memberTwo]

@hwc.terror: I suck at gpus but I wonder why this gpu would care about sse. I'm curious, can you upload the diff plz.
Edit: Hmm... Could it be related to floating point compatibility?

Originally Posted by RockmanForte

Why dont you people out there who doesnt have OGL make a petition lists and send to the developer and tell them that they should continue DX9. I hope they would listen and go for it.

Yeah sure "Join the Fix-that union guys, we'll make them yield"

---

Last edited by memberTwo; November 16th, 2008 at 08:59..

[MurraySkull]

No difference for me - I tried it with Melee - floors still black.

[omegadox]

Well hwc.terror, if you can fix up the DX9 plugin, why not just join the team? So you can commit the fixes. Just ask ector if you can join.

[hwc.terror]

@MurraySkull:
Aye the floor is still black, I need to look at that still, but the text issue and some textures is definately fixed, for me atleast (GM965).

Look at this:

Before



After



I asked someone on IRC, and he/she reported it was fixed for them too (using a GM945), we're talking about the text issue mainly here not the blackness bug in SSB.

What card do you have MurraySkull.

@memberTwo:
SSE is used in VideoCommon (XFBConvert and TextureDecoding) to decode the textures faster as oppposed to using regular arithmetics, but the decoded texture must have a different output since it messes up the graphics, I'll throw in a .diff and PM you / IRC or something.

@Axel32:
What happens, does it give you an error message? It should work really, make sure you actually replace the existing file, and make sure it ends with a .dll extension.

__________________
Vista Home Premium
Intel Core 2 Duo 1.66GHZ (T5450)
2048MB RAM
Integrated GFX: Intel X3100 358MB (Chipset: Intel Mobile Express GM965 (Pixel Shader 4, DX10))

(Toshiba A200-1YO Notebook)

[MurraySkull]

I have an nVIDIA GeForce 5700LE.

[hwc.terror]

Originally Posted by MurraySkull

I have an nVIDIA GeForce 5700LE.

Ah you have a nvidia card, well that explains.

This fix is really only for Intel cards

__________________
Vista Home Premium
Intel Core 2 Duo 1.66GHZ (T5450)
2048MB RAM
Integrated GFX: Intel X3100 358MB (Chipset: Intel Mobile Express GM965 (Pixel Shader 4, DX10))

(Toshiba A200-1YO Notebook)

---

Last edited by hwc.terror; November 16th, 2008 at 11:33..

[ector]

What kind of lameness is this?

If you know how to fix the bug, you PUBLISH THE SOURCE CODE FOR THE FIX and let us incorporate it into official Dolphin. If it looks good, we'll even give you access to SVN and let you submit the fix yourself.

Dolphin, and its default plugins, are under the GPL licence. Just releasing a compiled DLL like this, without providing the source code, is illegal.

Now, to fix this situation, you need to immediately release the source code change you did.

---

Last edited by ector; November 16th, 2008 at 13:16..

[hwc.terror]

Originally Posted by ector

What kind of lameness is this?

If you know how to fix the bug, you PUBLISH THE SOURCE CODE FOR THE FIX and let us incorporate it into official Dolphin. If it looks good, we'll even give you access to SVN and let you submit the fix yourself.

Dolphin, and its default plugins, are under the GPL licence. Just releasing a compiled DLL like this, without providing the source code, is illegal.

Now, to fix this situation, you need to immediately release the source code change you did.

That's the thing, it's not fixed at all, or in a way, it is but only for Intel users, since it disables the use of SSE completely for texture decoding, this means that NVidia/ATI cards won't benefit from SSE texture decoding, which could result in less performance, but in favour of compatibility.

I dont have any problems in releasing the source code for the fix, do you want me to post it here or PM it to you?

In fact this is what I was going to do anyway, I was just trying to add an checkbox in DolphinWx\GUI\ConfigMain, so users can switch on/off use of SSE Texture Decoding, this way, Intel users can disable it to make it work with their chipset, and ATI/NVidia can enable it to benefit from extra performance. Before I gave it to one of you guys

__________________
Vista Home Premium
Intel Core 2 Duo 1.66GHZ (T5450)
2048MB RAM
Integrated GFX: Intel X3100 358MB (Chipset: Intel Mobile Express GM965 (Pixel Shader 4, DX10))

(Toshiba A200-1YO Notebook)

[daco]

Originally Posted by hwc.terror

That's the thing, it's not fixed at all, or in a way, it is but only for Intel users, since it disables the use of SSE completely for texture decoding, this means that NVidia/ATI cards won't benefit from SSE texture decoding, which could result in less performance, but in favour of compatibility.

I dont have any problems in releasing the source code for the fix, do you want me to post it here or PM it to you?

In fact this is what I was going to do anyway, I was just trying to add an checkbox in DolphinWx\GUI\ConfigMain, so users can switch on/off use of SSE Texture Decoding, this way, Intel users can disable it to make it work with their chipset, and ATI/NVidia can enable it to benefit from extra performance. Before I gave it to one of you guys

wouldnt it be better to just auto check in the code what kind of gpu the person has?
that would be better imo cause it will end up with less options in dolphin...
on the other hand you could create more bugs :P

but ok, i was told it wasn't hard to do that check so idk

__________________


my DolphinWx rev Builds:
http://www.nyleveia.com/daco/
Njoy with rumble disabled:
32bit clickme and 64bit clickme

[Axel32]

its written 'Failed to load plugin Plugins\Plugin_VideoDX9.dll
help?

[omegadox]

Update your DirectX to November 2008?

[ector]

hwc.terror, the right way to do this is to rightclick your source folder, choose TortoiseSVN->Create Patch... . The result is a description of what code lines to change, which can be automatically applied. if the change is as simple as you say, it should be really short and could be pasted right here, or attached to a message or an issue in the issue tracker. Then someone from the project, me for example, will take a look and see if it's suitable for inclusion.